Skip to content

fix: Resolve relation aliases declared inside a parenthesized JOIN - #29158

Merged
ritchie46 merged 1 commit into
mainfrom
worktree-sql-paren-join
Sep 4, 2026
Merged

ritchie46 merged 1 commit into
mainfrom
worktree-sql-paren-join

Conversation

@ritchie46

@ritchie46 ritchie46 commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

fixes #29153

🤖 Generated with Claude Code

A nested join was always executed in an isolated context, discarding the
relation aliases and join-alias tracking it registered. Bare parentheses
around a join only group; they don't introduce a new scope, so the aliases
they declare must remain resolvable by the enclosing query. Isolation is now
kept only for an aliased nested join, which is a relation of its own.

Fixes #29153

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Md22nwt83n2SvcA1V7Vqqi
@ritchie46 ritchie46 changed the title fix(sql): Resolve relation aliases declared inside a parenthesized JOIN fix: Resolve relation aliases declared inside a parenthesized JOIN Sep 4, 2026
@github-actions github-actions Bot added A-sql Area: Polars SQL functionality fix Bug fix title needs formatting python Related to Python Polars rust Related to Rust Polars labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The uncompressed lib size after this PR is 54.7269 MB (at 210dc2e).

@ritchie46
ritchie46 merged commit d4b30e2 into main Sep 4, 2026
36 of 38 checks passed
@ritchie46
ritchie46 deleted the worktree-sql-paren-join branch September 4, 2026 15:29
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.68%. Comparing base (fec681c) to head (210dc2e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29158      +/-   ##
==========================================
+ Coverage   81.65%   81.68%   +0.02%     
==========================================
  Files        1905     1905              
  Lines      270933   270970      +37     
  Branches     3105     3105              
==========================================
+ Hits       221242   221342     +100     
+ Misses      48906    48845      -61     
+ Partials      785      783       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: Parenthesizing a JOIN in the FROM clause breaks column resolution

1 participant