Repository navigation
fix: Resolve relation aliases declared inside a parenthesized JOIN - #29158
Merged
Merged
Conversation
A nested join was always executed in an isolated context, discarding the relation aliases and join-alias tracking it registered. Bare parentheses around a join only group; they don't introduce a new scope, so the aliases they declare must remain resolvable by the enclosing query. Isolation is now kept only for an aliased nested join, which is a relation of its own. Fixes #29153 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Md22nwt83n2SvcA1V7Vqqi
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
September 4, 2026 14:30
Contributor
|
The uncompressed lib size after this PR is 54.7269 MB (at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29158 +/- ##
==========================================
+ Coverage 81.65% 81.68% +0.02%
==========================================
Files 1905 1905
Lines 270933 270970 +37
Branches 3105 3105
==========================================
+ Hits 221242 221342 +100
+ Misses 48906 48845 -61
+ Partials 785 783 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29153
🤖 Generated with Claude Code